Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pact merge v4 without provider states #7

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

YOU54F
Copy link
Owner

@YOU54F YOU54F commented Jun 6, 2024

todo

  • add test for merging pact duplicate interactions where existing pact contains multiple unique interaction types

    • with same provider state (optional)
    • without same provider state (optional)

    to repro Pact Merging Creates Duplicate Interactions pact-foundation/pact-reference#389 in pact_models (currently reproing, by copying built release binary to pact-net, and running tests locally. Prior exectution would result in Fulfilment API-Orders API.json having duplicated interactions on each separate test invocation)

  • cleanup commented out print statements (replace with debugs for troubleshooting later?)

check

  • does comparison logic need updating elsewhere, (pact v1-v3 files)

@YOU54F YOU54F merged commit c58b110 into master Jun 6, 2024
61 checks passed
@YOU54F YOU54F deleted the fix/pact_merge_v4_without_provider_states branch June 26, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant